Clean up topic commands to use UIDs instead of a global list #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was sure we had decls that autoset UID somewhere, but my regex-fu cannot find them. Seems fine conceptually so long as it's consistent. |
MistakeNot4892
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Cleans up topic commands. They now use abstract_type and UIDs instead of a bespoke
base_typevar and a global list of names -> commands.Might be a good idea to go back and remove the
namevar or have it auto-set UIDs (if we allow that?) or whatever.Why and what will this PR improve
Improves the code quality of topic commands, which hadn't been touched in like three years.