Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up topic commands to use UIDs instead of a global list #4160

Conversation

out-of-phaze
Copy link
Member

Description of changes

Cleans up topic commands. They now use abstract_type and UIDs instead of a bespoke base_type var and a global list of names -> commands.

Might be a good idea to go back and remove the name var or have it auto-set UIDs (if we allow that?) or whatever.

Why and what will this PR improve

Improves the code quality of topic commands, which hadn't been touched in like three years.

@out-of-phaze out-of-phaze added the ready for review This PR is ready for review and merge. label Jul 5, 2024
@MistakeNot4892
Copy link
Contributor

I was sure we had decls that autoset UID somewhere, but my regex-fu cannot find them. Seems fine conceptually so long as it's consistent.

@MistakeNot4892 MistakeNot4892 merged commit 17fa8d8 into NebulaSS13:dev Jul 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants